[m-rev.] for post-commit review: fix mantis bug #522

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Mar 17 14:03:22 AEDT 2022


As it happens, I could debug bug 552 without an mmc --make
equivalent of lmc, because as the attached HLDS dump shows,
the only nontrivial code between the definition and the use of
Text_287, the variable for which the map.lookup failed, was
a negation. The attached main diff fixes this bug, and the extra
diff fixes minor issues I found while looking for the bug.
For review by anyone.

By the way, I tried but failed to create a test case for this bug.
The reason is that the heart of the bug here is the code
`not (true, false)', and I didn't have the patience to try to
find a way to get this code to the code generator *without*
having the pre-codegen simplification pass delete the whole goal.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.bug552
Type: application/octet-stream
Size: 792 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220317/b55efe1b/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.bug552
Type: application/octet-stream
Size: 4116 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220317/b55efe1b/attachment-0004.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: display_report.hlds_dump.430-mark_tail_calls.gz
Type: application/x-gzip
Size: 11342 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220317/b55efe1b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.extras
Type: application/octet-stream
Size: 9652 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220317/b55efe1b/attachment-0005.obj>


More information about the reviews mailing list