[m-rev.] for review: io.primitives_{read,write}.m

Zoltan Somogyi zoltan.somogyi at runbox.com
Sat Mar 12 16:48:41 AEDT 2022


2022-03-12 15:53 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
> 
> On Sat, 12 Mar 2022, Zoltan Somogyi wrote:
> 
>> I just noticed that two of the predicates moved to io.primitives_read.m,
>> putback_byte_2 and putback_uint8_2, seem to have identical implementations.
>> One should be deleted with all uses replaced by the other, but which one
>> should stay? I don't care, but we should pick just one.
> 
> My intention is to eventaully deprecate and then remove those
> operations that represent bytes using the lower 8 bits of an int.
> In that case, the version to keep is the uint8 version.

For your post-commit review.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.pbb
Type: application/octet-stream
Size: 131 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220312/833fba76/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.pbb
Type: application/octet-stream
Size: 2661 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220312/833fba76/attachment-0001.obj>


More information about the reviews mailing list