[m-rev.] diff: Fix decode_system_command_exit_code returning negative signal numbers.
Peter Wang
novalazy at gmail.com
Tue Mar 8 13:28:50 AEDT 2022
On Tue, 08 Mar 2022 13:27:22 +1100 Julien Fischer <jfischer at opturion.com> wrote:
>
> Hi Peter,
>
> On Tue, 8 Mar 2022, Peter Wang wrote:
>
> > library/io.call_system.m:
> > As above.
> >
> > diff --git a/library/io.call_system.m b/library/io.call_system.m
> > index 2f11b417d..d1144204c 100644
> > --- a/library/io.call_system.m
> > +++ b/library/io.call_system.m
> > @@ -316,7 +316,7 @@ decode_system_command_exit_code(Code0) = Status :-
> > Status = WEXITSTATUS(Status0);
> > } else if (WIFSIGNALED(Status0)) {
> > Signalled = MR_YES;
> > - Signal = -WTERMSIG(Status0);
> > + Signal = WTERMSIG(Status0);
> > }
> > #else
> > Exited = MR_YES;
>
> I assume this needs to go on the release branch as well?
Yes.
Peter
More information about the reviews
mailing list