[m-rev.] for post-commit review: io.environment.m and io.call_system.m

Zoltan Somogyi zoltan.somogyi at runbox.com
Tue Mar 8 11:36:52 AEDT 2022


2022-03-08 11:04 GMT+11:00 "Peter Wang" <novalazy at gmail.com>:
> The rest is fine.

As shown by the attached committed diff, I followed
all your suggestions. Thanks for the review.

Given that decode_system_command_exit_code is used
in two modules, and does not seems to require any implementor-
level understanding to use, should we make it a *documented*
part of io.call_system.m?

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.ecs2
Type: application/octet-stream
Size: 239 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220308/f9ab1afa/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.ecs2
Type: application/octet-stream
Size: 7591 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220308/f9ab1afa/attachment-0003.obj>


More information about the reviews mailing list