[m-rev.] for review: read and write bitmaps in bitmap.m

Julien Fischer jfischer at opturion.com
Mon Mar 7 11:49:53 AEDT 2022


On Sat, 5 Mar 2022, Zoltan Somogyi wrote:

> 2022-03-05 21:09 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>> There is an issue with read_file_as_string in the C# grade at the moment
>> and that is causing additional failures in that grade.
>
> I think that some of those failures may be due to an incorrectly-coded
> sanity test in parse_module.m, on line 508, which insists on the number
> of code units in the file being the same as its string length, but the length
> counts code *points*, not units.

No, string.length counts code units.  There appears to be a problem with
the C# version of io.read_file_as_string_and_num_code_units when the
file contains non-BMP(?) code points (e.g. the emoji in
tests/hard_coded/char_to_string.m).

>> I'll set some bootchecks in those grades and get you some accurate
>> counts.

I get 289 failures in the C# grade, of which about a dozen are due
to the above.

Julien.


More information about the reviews mailing list