[m-rev.] for post-commit review: organize array.m, bt_array.m and pprint.m

[Zoltan Somogyi]

2022-06-09 10:47 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
> On the name: I think ra_list is fine.  (After all, we already have
> kv_list, rtree, rbtree, etc. and the longer name is unwieldly.)
> 
> I'm not convinced that ra_lists need to be a documented part
> of the standard library, but don't really have any objection if
> others feel they should be.

The attached diff adds ra_list.m to the Mercury standard library
as a documented module, but making it undocumented would
be trivial. For review by anyone.

> (Actually, I think the bt_array module should be dropped from the
> standard library entirely, since it doesn't really provide anything
> that the array or version_array modules don't also provide.)

I have never used either bt_array or version_array, so I would not miss
bt_array if it were deleted, but someone might.

>> +    % array.sort was previously buggy. This symbol provides a way to ensure
>> +    % that you are using the fixed version.
>> +    %
>> +:- pred array.sort_fix_2014 is det.
>>
> 
> I think we can delete sort_fix_2014 now.

The attached diff does this.

> The diff looks fine.

Thanks for the review.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.ral
Type: application/octet-stream
Size: 1274 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220609/72c8f8d1/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.ral
Type: application/octet-stream
Size: 27826 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220609/72c8f8d1/attachment-0003.obj>