[m-rev.] for review: --warn-actually-ambiguous-pragmas

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Jul 28 16:19:38 AEST 2022


2022-07-28 15:00 GMT+10:00 "Peter Wang" <novalazy at gmail.com>:
> We could call the option --warn-ambiguous-pragmas, no "actually".
> I also think the warning can be enabled by default.

OK, I will do both those things.

> Moreover, I would be surprised if any real code relies on a single
> pragma applying to both a predicate and function. It should be fine to
> always report an error for an ambiguous pragma, and delete the option.
> That could be done in a later change.

OK.

>> tests/invalid_nodepend/fact_table_in_interface.err_exp:
>>     Expext the updated wording of a warning.
> 
> Expect

Done.

Do you have an opinion on the questions I asked about the
documentation?

Thanks for the review.

Zoltan.


More information about the reviews mailing list