[m-rev.] diff: fix a bug in tools/import_srcdist

Julien Fischer jfischer at opturion.com
Thu Jan 27 01:33:08 AEDT 2022


Hi Peter,

On Thu, 27 Jan 2022, Peter Wang wrote:

> On Wed, 26 Jan 2022 23:52:09 +1100 Julien Fischer <jfischer at opturion.com> wrote:
>>
>> Fix a bug in tools/import_srcdist.
>>
>> tools/import_srcdist:
>>      Add files with the -f (--force) option; otherwise files that
>>      match patterns in .gitignore will be ignored.
>>
>
> Ouch.

Indeed. I'm assuming git add changed its default behaviour at some point
since up until around September 2020 things were fine.  Ideally, the
script should also check that, say, compiler/mercury_compile.c has been
imported into git.

> I wrote a quick script to check which tags are affected.
> The results are below. I still have most, maybe all,
> of the "old" tarballs so I can re-import them.

I probably have some others.

> I also have a smattering of the newer tarballs that I downloaded.
> Perhaps you have a more complete set somewhere?

I have some of them -- they're just rotd package, so having them
all is not that important.

> Otherwise, we can just import what we have, and delete any broken
> tags.

I assume you can modify the script you have below to delete the
broken tags?

Julien.


More information about the reviews mailing list