[m-rev.] for review: check library install just once

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed Jan 12 16:44:42 AEDT 2022


2022-01-12 16:37 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>> You just found the bug in my not-yet-finished change :-)
> 
> Not only that, I suspect I put the bug there in the first place ;-)

No, you didn't. The code you added in handle_options.m that sets
libgrade_install_check to "no" except in the two intended use cases
seems correct. My incomplete diff is about avoiding invoking
that code altogether. Your code did not do its job, but the reason
is that it wasn't called :-)

Zoltan.


More information about the reviews mailing list