[m-rev.] for possible post-commit review: carve three modules out make.m

Julien Fischer jfischer at opturion.com
Tue Jan 11 23:18:45 AEDT 2022


On Mon, 10 Jan 2022, Zoltan Somogyi wrote:

> Carve three modules out of make.m.

...

> diff --git a/compiler/notes/compiler_design.html b/compiler/notes/compiler_design.html
> index 49d3bb475..740703e3d 100644
> --- a/compiler/notes/compiler_design.html
> +++ b/compiler/notes/compiler_design.html
> @@ -205,9 +205,12 @@ which contains the following modules:
>
>  <ul>
>  <li>
> -make.m categorizes targets passed on the command line
> +make.top_level.m categorizes targets passed on the command line
>  and passes them to the appropriate module to be built.
>  <li>
> +make.track_flags.m keeps a database that records
> +which options were used to compile each module.
> +<li>
>  make.program_target.m handles whole program `mmc --make' targets,
>  including executables, libraries and cleanup.
>  <li>
> @@ -224,6 +227,9 @@ between compilations.
>  <li>
>  make.build.m provides the machinery required to bring targets up to date.
>  <li>
> +make.info.m defines the main data structure

s/make.info.m/make.make_info.m/

> +used by all the make*.m modules above.
> +<li>
>  make.util.m contains utility predicates.

>  <li>
>  options_file.m reads the options files specified by

That looks fine otherwise.

Julien.


More information about the reviews mailing list