[m-rev.] for review: fix octal encoding bug in extras/graphics/mercury_allegro/samples

Fabrice Nicol fabrnicol at gmail.com
Wed Jan 5 12:51:00 AEDT 2022


A final modest proposal for review by anyone.

-------------------------------------------------------------

Bug issue (fixed):

samples/demo/title.m:

samples/mandel/mandel.m:

         Compilation crashes due to illegal (perhaps obsolete) octal 
encoding

         of 'Escape' Ascii character.

---------------------------------------------------------

Proposed fix:

         - Change illegal '\033' into legal 0o033

         - Module char should be imported as int value has to be cast to 
char type.

Incidentally, added tested version 4.4.x  of allegro library to README.

---------------------------------------------------------

Fix was tested under Gentoo Linux (amd64 branch, freeglut v.3.2.1, mesa 
v.21.2.6) by building all allegro samples.

Fabrice
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-issues-with-octal-Escape-encoding.patch
Type: text/x-patch
Size: 2598 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220105/20e12a84/attachment.bin>


More information about the reviews mailing list