[m-rev.] for post-commit review: simplify printing class decls

Zoltan Somogyi zoltan.somogyi at runbox.com
Sat Feb 12 19:22:14 AEDT 2022


2022-02-12 17:12 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>> Next, I intend to take the code for printing the kinds
>> of class decls that we used get with hl grades (which we
>> deleted in april 2020) but which we don't get with
>> hlc grades, and replace them with calls to unexpected,
>> leaving the old code as comments and/or as dead
>> predicates with consider_used pragmas.
>> If you object to this, please speak up.
> 
> I don't object, but I do have a query.  Is --dump-mlds still using that
> code when printing MLDS dumps for the Java or C# grades?

At the moment, dumping the MLDS, or selected parts of it,
- generates C code when targeting C,
- generates a pprint.doc and writes that out when targeting
  anything other than C.

However, someone sometime in the future may want to see
an MLDS dump in C syntax even in the second case, so I will leave
all the old code in mlds_to_c*.m, but document which parts are expected
to be generated only when *not* targeting C.

Zoltan.


More information about the reviews mailing list