[m-rev.] diff: simplify code constructing pred names

[Zoltan Somogyi]

2022-02-07 16:53 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
> 
> On Mon, 7 Feb 2022, Zoltan Somogyi wrote:
> 
>> The diff is not really worth reviewing, but it does raise
>> a question. At the moment, there are several modules
>> that construct new pred names (this diff affects two of them).
>> There is no overall pattern, and what partial pattern does exist
>> is, in my opinion, flawed, for reasons documented in the XXXs
>> added by this diff.
> 
> I suspect the situation may be worse than there just be a lack of an
> overall pattern; it's likely some things currently only work by
> accident.

I agree.

>> Would anyone object if I moved all the code that constructs
>> new pred names to a new module, pred_name.m?
> 
> No objections from me, I think that would be a worthwhile (and very
> overdue) change.

The attached diff does this. It just moves code around, so the
only bit worth looking at is the new entry in compiler_design.html.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.pn2
Type: application/octet-stream
Size: 520 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220208/f1fdf096/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.pn2
Type: application/octet-stream
Size: 21989 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220208/f1fdf096/attachment-0003.obj>