[m-rev.] for post-commit review: specialize one fold, move two
Peter Wang
novalazy at gmail.com
Fri Dec 2 14:37:43 AEDT 2022
On Thu, 01 Dec 2022 16:11:54 +1100 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> Move foldl3_* predicates out of make.build.m.
>
> compiler/make.track_flags.m:
> Move foldl3_maybe_stop_at_error_sn here, since it is only used here,
> along with a copy of foldl3_maybe_stop_at_error_loop, then
>
> - inline it at its only call site, and
> - delete the now-unused predicate.
>
> Simplify the local copy of foldl3_maybe_stop_at_error_loop
> by specializing it to its only set of top level arguments,
> and rename it after its now-singular purpose.
>
> compiler/make.dependencies.m:
> Move foldl3_maybe_stop_at_error_{mi,fi} here, together with
> foldl3_maybe_stop_at_error_loop, and the type and inst it uses,
> since they are only called from here. There are not any changes
> in the code moved here (yet).
>
> compiler/make.build.m:
> Delete the moved code.
That's fine.
Peter
More information about the reviews
mailing list