[m-rev.] for review: Improve io.dir.m for Java and C#.
Julien Fischer
jfischer at opturion.com
Fri Aug 26 12:50:33 AEST 2022
On Thu, 25 Aug 2022, Peter Wang wrote:
> Make the following improvements to io.dir.m for Java and C#.
> The changes to throwing more specific exception types is because
> the exception objects can now be inspected by the user through io.m.
>
> make_directory [C#]:
> Delete redundant check for an existing file of the same name
> as the directory to be created.
>
> make_directory [Java]:
> Throw more specific exception.
>
> Capitalise first letter in error messages.
>
> make_single_directory [C#]:
> make_single_directory [Java]:
> Delete redundant check for an existing file of the same name
> as the directory to be created.
>
> Delete unnecessary check for attempt create root directory.
>
> Throw more specific exceptions and improve error messages.
>
> open [Java]:
> Throw more specific exception.
>
> diff --git a/library/dir.m b/library/dir.m
> index 15a13c334..6f26033b9 100644
> --- a/library/dir.m
> +++ b/library/dir.m
> @@ -178,6 +178,8 @@
> % This will also succeed if the directory already exists
> % and is readable and writable by the current user.
> %
> + % XXX Why does this check for read/writability by the current user?
> + %
Why is that an issue?
That looks fine otherwise.
Julien.
More information about the reviews
mailing list