[m-rev.] for review: carve four modules out of term.m

[Zoltan Somogyi]

2022-08-23 12:28 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
>> The attached diff does this. It is mostly boring and not worth looking at,
>> but I would like you all to look at the new term_context.m and see whether
>> you agree with the updated names of some functions, and with the fact that
>> the diff effectively deletes predicates that duplicate the functionality of
>> functions. These are marked with ZZZs, so they can be added back in
>> if people want them.
> 
> Removing the predicates marked with ZZZ is fine by me.

Done.

>> +%---------------------------------------------------------------------------%
>> +% vim: ts=4 sw=4 et ft=mercury
>> +%---------------------------------------------------------------------------%
>> +% Copyright (C) 1993-2000,2003-2009,2011-2012 The University of Melbourne.
>> +% Copyright (C) 2014-2022 The Mercury team.
>> +% This file is distributed under the terms specified in COPYING.LIB.
>> +%---------------------------------------------------------------------------%
>> +%
>> +% File: term.m.
>> +% Main author: fjh.
>> +% Stability: medium.
>> +%
>> +% This file provides a type `term' used to represent Herbrand terms,
>> +% and various predicates to manipulate terms and substitutions.
> 
> That description is a copy-and-paste error.

Fixed, though it was not copied-and-pasted; I used the split_file script :-)
That is what I wrote it for.

>> +:- type term_context
>> +    --->    context(string, int).
>> +            % file name, line number.
> 
> Is there any particular reason not to turn the above into field names?

I added field names.

> That's fine otherwise.

Thank you.

Zoltan.