[m-rev.] for review: delete obsolete procedures from string module

[Julien Fischer]

On Wed, 13 Apr 2022, Zoltan Somogyi wrote:

> 2022-04-13 16:11 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:

...

>> @@ -1777,12 +1734,8 @@
>>  to_char_list(S) = Cs :-
>>      to_char_list(S, Cs).
>>
>> -:- pragma promise_equivalent_clauses(pred(to_char_list/2)).
>> -
>>  to_char_list(Str::in, CharList::out) :-
>>      do_to_char_list(Str, CharList).
>> -to_char_list(Str::uo, CharList::in) :-
>> -    from_char_list(CharList, Str).
>>
>
> I would delete the modes on the args, since they are not needed anymore.

Fixed.  Redundant modes on clauses seems like the kind thing the
compiler should warn about.

I have followed your other suggestions.

Julien.