[m-rev.] for review: record source items in type_ctor_checked_defns

[Peter Wang]

On Tue, 07 Sep 2021 09:59:45 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> For review by Peter. The diff to the documentation is for
> post-commit review.
> 
> I want to add code to what is now check_parse_tree_type_defns.m
> to also check inst and mode definitions for consistency, but this would
> seem to require a change in the file name. Would anyone object to
> check_type_inst_mode_defns.m?
> 
> Zoltan.

No objection, but will the file not be too big?

>  build_mercury_foreign_enum_map(TypeCtor, CtorNames, CtorNamesSet,
> -        ForeignEnum, {CheckedForeignEnum, Specs}) :-
> +        ForeignEnum, MaybeCheckedForeignEnum) :-
>      ForeignEnum = item_foreign_enum_info(_Lang, _TypeCtor, MercuryForeignOoM,
>          Context, _SeqNum),
>      MercuryForeignAL = one_or_more_to_list(MercuryForeignOoM),
> -    ContextPieces = [words("In"), pragma_decl("foreign_export_enum"),
> +    ContextPieces = [words("In"), pragma_decl("foreign_enum"),
>          words("declaration for type"), unqual_type_ctor(TypeCtor),
>          suffix(":"), nl],

Hmm, this mistake doesn't seem easy to trigger.

The rest looks fine. I noticed that the type_details_du field name
'du_supertype' should be changed.

> diff --git a/doc/reference_manual.texi b/doc/reference_manual.texi
> index 0e2099966..c563b0855 100644
> --- a/doc/reference_manual.texi
> +++ b/doc/reference_manual.texi

That's ok.

Peter