[m-rev.] for review: checked defns in parse_tree_module_src

[Zoltan Somogyi]

2021-10-16 16:50 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>> Since the section mismatch between the two declarations
>> was the only error in the test case, making it not an error
>> makes the test case fail by having the compiler exit
>> with a success exit code.
>>
>> I could make the compiler generate an error for this case,
>> but I don't think that would be a good idea, since that would
>> complicate the relatively simple rule "redundant declarations
>> get at most a warning". This would require moving the test case
>> to tests/warnings. Does anyone object to this move?
> 
> No.

Ok, I will move the test case.

>> > compiler/add_type.m:
>>     Comment out an error message for a condition that will be detected and
>>     reported by check_type_inst_mode_defns.m.
> 
> Is there a reason you are not removing it?

It does not matter: I am about to replace much of add_type.m,
including that code.

I followed your other suggestions.

> That looks fine otherwise.

Thanks for the review.

Zoltan.