[m-rev.] for post-commit review: fix infinite loop bug in compiler

Zoltan Somogyi zoltan.somogyi at runbox.com
Sat Oct 16 12:14:37 AEDT 2021


2021-10-13 13:07 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
> Rather than printing the .intN contexts, we could just give the context
> of the insts in the module being compiled and say something like:
> 
>       ... and the imported insts `foo' and `bar'.
> 
> 
> (i.e. we would have two different forms of the error message dependent
> on whether it refers to an imported insts / modes.)

I went with a variation of this: always printing all the inst names in a cycle
as a list, and then following it up with messages that say "inst iN is defined here"
after iN's context for just the local insts.

For post-commit review by Julien.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.circ2
Type: application/octet-stream
Size: 1098 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20211016/530135f7/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.circ2
Type: application/octet-stream
Size: 32438 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20211016/530135f7/attachment-0003.obj>


More information about the reviews mailing list