[m-rev.] for post-commit review: fix failure of hard_coded/trace_goal_opt
Zoltan Somogyi
zoltan.somogyi at runbox.com
Fri Oct 1 16:00:11 AEST 2021
2021-10-01 13:27 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
>> @@ -2181,6 +2181,57 @@ write_goal_scope(!.Info, Stream, ModuleInfo, VarSet, TypeQual, VarNamePrint,
>> ;
>> MaybeRunTime = no
>> ),
>> + Lang = get_output_lang(!.Info ^ hoi_merc_out_info),
>> + (
>> + Lang = output_mercury,
>> + % After we have read in trace goals as expressions,
>> + % goal_expr_to_goal.m, in the process of converting
>> + % those goal_exprs to HLDS goals, wraps the goal
>> + % in the scope with code to get and set the I/O state
>> + % and/or any mutables mentioned by the scope.
>> + %
>> + % Therefore when generate Mercury code, we don't write
>
> s/generate/generating/
I did s/generate/we generate/ instead.
> Is the comment reading "quantified vars []" really supposed to be present
> in the .opt file?
It is supposed to be in HLDS dumps, but I deleted it from non-debug output.
Zoltan.
More information about the reviews
mailing list