[m-rev.] for review: centralize adding items in make_hlds_passes.m.
Julien Fischer
jfischer at opturion.com
Mon May 24 21:49:20 AEST 2021
On Mon, 24 May 2021, Zoltan Somogyi wrote:
> For review by anyone.
> Centralize HLDS building in make_hlds_passes.m.
>
> compiler/add_mutable_aux_preds.m:
> compiler/add_solver.m:
> When invoked on mutables and solver types respectively, these modules
> added did all the additions to the HLDS directly themselves,
> in two phases: first declarations, then definitions.
>
> Change this so that instead, they simply return the items needed
> to declare and define mutables and solver types to make_hlds_passes.m,
> which will then add them to the HLDS with the other items of the same kind.
...
That looks fine.
Julien.
More information about the reviews
mailing list