[m-rev.] for review: add bitwise rotations for uint32s

Julien Fischer jfischer at opturion.com
Sun Mar 28 14:27:33 AEDT 2021



On Sun, 28 Mar 2021, Zoltan Somogyi wrote:

> 2021-03-28 02:22 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>> +*** Test 'rotate_left' ***
>
> I would change the test case code to print the results of unchecked_rotate_dir for a given
> pair of input args just after rotate_dir, so that these two lines would be next to each other
> (and lined up to make a visual diff trivial).
>
>> +                      rotate_left(00000000000000000000000000000001, 0) = 00000000000000000000000000000001
>> +unchecked_rotate_left(00000000000000000000000000000001, 0) = 00000000000000000000000000000001

I forgot to address the in the mail, but this is also done.

Julien.


More information about the reviews mailing list