[m-rev.] for review: explicit streams in the browser directory

[Zoltan Somogyi]

2021-03-05 20:02 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
> There's a couple of existing problems there.  The object file extension is not
> always ".o" (although at the moment, it will be so on any system that actually
> supports interactive queries.)  The shared object extension is *not* always
> ".so", on macOS (which does support interactive queries) it will be ".dylib".
> 
> I would add an XXX about the first and change the last line to:
> 
>     cleanup_file("lib", shlib_extension, !IO).

Done.

>> +report_exception(OutputStream, Excp, !IO) :-
>> +    io.write_string(OutputStream, "*** caught exception: ", !IO),
>> +    io.write_cc(OutputStream, Excp, !IO),
>> +    io.nl(OutputStream, !IO).
> 
> Hmmm, we should definitely add a version of write_line_cc that takes an
> output_stream argument.

Done, in a separate commit.

> The rest looks fine.

Thank you.

Zoltan.