[m-rev.] diff: disable tabling tests in hlc.par grades

Julien Fischer jfischer at opturion.com
Thu Jun 17 20:41:44 AEST 2021


Disable tabling tests in the hlc.par grades.

tests/tabling/Mmakefile:
      As above.

      Delete code that disabled the tabling tests in the now removed hl.*
      grades.

Julien.

diff --git a/tests/tabling/Mmakefile b/tests/tabling/Mmakefile
index d362824..ee7737c 100644
--- a/tests/tabling/Mmakefile
+++ b/tests/tabling/Mmakefile
@@ -161,41 +161,23 @@ else
  	PROGS0 =
  endif

-# Tabling is buggy in the lowlevel .par grades so it's disabled for now.
-# XXX What is the bug? If it is lack of synchronization on table updates,
-# why are these tests enabled for hlc par grades?
+# Tabling is disabled in all .par grades due to the lack of synchronization on
+# table updates.
  ifeq "$(findstring .par,$(GRADE))" ""
  	PROGS1 = $(PROGS0)
  else
-	ifeq "$(findstring hl,$(GRADE))" ""
-		PROGS1 =
-	else
-		PROGS1 = $(PROGS0)
-	endif
+	PROGS1 =
  endif

-# Disable these tests in MLDS grades (targeting C, C# and Java)
+# Disable these tests in MLDS grades (C, C# and Java)
  # with high level data representation, because tabling is not implemented
  # for high level data representation.
  ifneq "$(findstring java,$(GRADE))$(findstring csharp,$(GRADE))" ""
  	# This is either the C# grade or the Java grade.
  	PROGS =
  else
-	ifneq "$(findstring hl,$(GRADE))" ""
-		# This is either a hl.* grade (high level data)
-		# or a hlc.* grade (low level data).
-		ifeq "$(findstring hlc,$(GRADE))" ""
-			# This is a hl.* grade.
-			PROGS =
-		else
-			# This is a hlc.* grade.
-			PROGS = $(PROGS1)
-		endif
-	else
-		# This is not a high level data grade, since those
-		# are all covered above.
-		PROGS = $(PROGS1)
-	endif
+	# This is a C grade.
+	PROGS = $(PROGS1)
  endif

  TESTS = $(sort $(PROGS))


More information about the reviews mailing list