[m-rev.] for review: use explicit streams in fact_table.m

Zoltan Somogyi zoltan.somogyi at runbox.com
Tue Jun 8 07:52:49 AEST 2021

2021-06-07 21:11 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
>> +                pred_info_get_orig_arity(PredInfo, PredFormArity),
>> +                user_arity_pred_form_arity(PredOrFunc,
>> +                    user_arity(UserArityInt), pred_form_arity(PredFormArity)),
>> +                PFStr = pred_or_func_to_full_str(PredOrFunc),
>> +                string.format("Error: invalid clause for %s `%s/%d'.",
>> +                    [s(PFStr), s(PredName), i(UserArityInt)], Msg),
> It's an existing problem, but there are specific components in error_util
> that should be used in the above error message.

I modernised all the code fragments that construct error messages.

>> +    % XXX This sends the output to the *input* file.
>> +    % This works in the usual implementations of sort,
>> +    % since you have to finish reading the input before you can generate
>> +    % any part of the output, but it is not *guaranteed* to work,
>> +    % since sort may *open* the output file before finishing reading.
> The other issue here is that it only works on systems that actually provide the
> sort and cut utilties.

I added another XXX to mention that.

> The diff is fine.

Thanks for the review,


More information about the reviews mailing list