[m-rev.] for post-commit review: a start on getting type repn info from .int files

Julien Fischer jfischer at opturion.com
Wed Jul 28 00:54:21 AEST 2021


Hi Zoltan,

On Wed, 28 Jul 2021, Zoltan Somogyi wrote:

> Create invalid_nodepend and invalid_onlydepend.
> 
> tests/invalid_onlydepend:
>     Move the one test case in tests/invalid for which we want to check
>     the error messages generated during the generation of dependencies
>     to this new test directory.
> 
> tests/invalid_nodepend:
>     Move all test cases in tests/invalid which get errors during the
>     generation of dependencies but for which we want to check the error
>     messages generated during normal compilation to this new test directory.
> 
> tests/invalid_nodepend/Mmakefile:
> tests/invalid_nodepend/Mercury.options:
> tests/invalid_onlydepend/Mmakefile:
> tests/invalid_onlydepend/Mercury.options:
>     Versions of the same files in tests/invalid, but containing only
>     the entries relevant to the moved test cases.
> 
> tests/invalid/Mmakefile:
> tests/invalid/Mercury.options:
>     Delete the entries that refer to the moved test cases.
> 
> tools/bootcheck:
>     Add invalid_onlydepend and invalid_nodepend to the list of
>     test directories.

You also need to describe the new directories in tests/README.
Other than that, the diff looks fine.

Julien.


More information about the reviews mailing list