[m-rev.] for review: add uint->uintN conversions

Julien Fischer jfischer at opturion.com
Thu Jul 1 00:07:46 AEST 2021


On Wed, 30 Jun 2021, Zoltan Somogyi wrote:

> 2021-06-30 22:39 GMT+10:00 "Zoltan Somogyi" <zoltan.somogyi at runbox.com>:
>> I have just written the 8, 16 and 32 bit versions. The first two work.
>> The third does not, because string.m has to_int, but not to_uint :-(.
>> I am fixing that right now.
>
> Attached is my updated diff. You will want to have a look at the change
> to string.m.

That looks fine.

> BTW, is the lack of lower/upper bounds on the base in base_string_to_int
> intentional, or not? Either way, for now at least, base_string_to_uint
> does not have bounds either.

Aren't the bounds enforced by the call to char.base_digit_to_int/3?

Julien.


More information about the reviews mailing list