[m-rev.] diff: use global registers on aarch64

Julien Fischer jfischer at opturion.com
Wed Jan 13 20:43:59 AEDT 2021


On Wed, 13 Jan 2021, Zoltan Somogyi wrote:

>
> 2021-01-13 20:34 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>>>> configure.ac:
>>>>      Compile with -fomit-frame-pointer on aarch64.
>>> I see no evidence of this in the diff to configure.ac.
>>
>> @@ -2420,10 +2420,11 @@ case "$ac_cv_prog_gcc" in yes)
>>               mercury_cv_gcc_labels=no
>>               ;;
>>           aarch64*)
>> -        # The test for GCC labels goes into a loop on AArch64.
>> +            # The test for GCC labels goes into a loop on AArch64.
>>               MERCURY_MSG("gcc labels do not work on AArch64")
>>               mercury_cv_asm_labels=no
>>               mercury_cv_gcc_labels=no
>> +            CFLAGS_FOR_REGS="-fno-omit-frame-pointer"
>>               ;;
>
> That specifies *keeping* the frame pointer, not omitting it.

Good catch, it shouldn't do that.

Julien.


More information about the reviews mailing list