[m-rev.] for review: direct_arg_in_out
zoltan.somogyi at runbox.com
Tue Jan 5 19:07:48 AEDT 2021
2021-01-05 12:03 GMT+11:00 "Peter Wang" <novalazy at gmail.com>:
> On Mon, 04 Jan 2021 21:13:49 +1100 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
>> 2021-01-04 18:17 GMT+11:00 "Peter Wang" <novalazy at gmail.com>:
>> > Do we have a test where the merged variable is used after a branching goal?
>> Not yet. While I add tests for this and ...
>> > It might be worth adding a test involving if-then-else.
>> ... for this, you might want to review the attached addition to the start-of-module
>> comment, describing the reasons for choosing not to modify the code generators.
Thanks for that. I have followed all your suggestions. The tests I added revealed
a bug, which I have fixed.
I can't commit this diff until commit a93fbc92f6bdeea7b58868c23e3f1970aa55116d
is in an ROTD. But there was a commit on jan 4th, which means that an ROTD
*should* have been generated last night, but there wasn't. Does anyone know
the reason for that?
More information about the reviews