[m-rev.] for post-commit review: fix Mantis bug 529

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Feb 25 11:50:19 AEDT 2021


2021-02-25 11:44 GMT+11:00 "Peter Wang" <novalazy at gmail.com>:
> I have started on the mode checker. It's roughly working, with a lot of
> details still to work through, but so far the change is isolated.
> modecheck_goal_generic_call needs to handle a new type of "cast" (coerce)
> by calling a new predicate. There shouldn't be any real conflicts unless
> you plan on large refactorings. (But go ahead and commit your changes if
> they are ready.)

I just committed a change to modecheck_unify.m, addressing your
review comment. I am bootchecking a cleanup diff to inst_match.m,
which I will commit when that succeeds.

I think it is likely that many/most of the places that will need to pick up
higher order inst info from types is in inst_match.m, not in mode*.m.
Do you think you will need to modify that file? If not, I can continue
my work on it.

Zoltan.


More information about the reviews mailing list