[m-rev.] for review: fix silent failure of making .int file

[Julien Fischer]

On Fri, 17 Dec 2021, Zoltan Somogyi wrote:

>
> 2021-12-17 19:05 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>>> 2. When making interface files, we could decide whether to treat warnings
>>>   as errors not based on the value of --halt-at-warn, but based on the value
>>>   of a new option, maybe called --interface-halt-at-warn, which could be
>>>   set independently. With this option, warnings could still be printed
>>>   at interface generation time, but would not prevent programmers
>>>   prioritizing fixing issues in other modules first.
>>>
>>> I myself would prefer 2 over both 1 and the status quo. Any other opinions?
>>
>> I prefer option 2.
>
> The attached diff implements option 2, extended with a separate option
> for compiler invocations that make .opt and .trans_opt files.
>
> For post commit review by Julien, mostly of the option names and the documentation,
> since that is pretty much all there is.
>
> I intend to add --nohalt-at-warn-{int,opt} to LIB_FLAGS.in, COMP_FLAGS.in etc
> in a week, after everyone has had a chance to install this diff.

...

> Add --halt-at-warn-make-{int,opt}.
> 
> compiler/options.m:
> doc/user_guide.texi:
>     Add these two new options, which function as --halt-at-warn when
>     generating interface files and optimization files respectively.
>     Document them both for users and for developers.
> 
> compiler/handle_options.m:
>     Set --halt-at-warn from --halt-at-warn-make-int when making interface
>     files, and from --halt-at-warn-make-opt when making optimization files,
>     allowing the test of the compiler to look at only --halt-at-warn.

That's fine.

Julien.