[m-rev.] for review: parse promises

Zoltan Somogyi zoltan.somogyi at runbox.com
Tue Dec 7 17:05:42 AEDT 2021



On Tue, 7 Dec 2021 16:59:31 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:

> 
> 
> On Tue, 7 Dec 2021, Zoltan Somogyi wrote:
> 
> > Add missing code for parsing 'promise_ex's.
> > 
> > compiler/parse_item.m:
> >     Add previusly missing code for parsing promise_ex declarations
> 
> s/previusly/previously/

Done.

> If module C has been provided to you by a third-party and you do not
> have its source code, you may have to make promises regarding its predicates
> in module B.  That's not an objection to the above change, I'm just
> noting that there is a possible use-case where promises in interfaces
> that refer to entities from another module make sense.

I added this scenario to the log message.

> The diff looks fine.

Thank you.

Zoltan.


More information about the reviews mailing list