[m-rev.] for post-commit review: gather pred decls

Julien Fischer jfischer at opturion.com
Tue Dec 7 01:45:16 AEDT 2021


On Mon, 6 Dec 2021, Zoltan Somogyi wrote:

> Gather pred declarations.
> 
> compiler/intermod.m:
>     Gather pred declarations, and print them as a whole. Delete some code
>     that duplicates functionality in parse_tree_out_pred_decl.m.
>
>     Print the declarations of all predicates the same way, using
>     print_name_only for any type variables in the predicate's signature.
>     We used to print type variables this way if the predicate has foreign code,
>     where it is required (due to the possible presence of TypeInfo_for_T
>     variables in the foreign code), but we used to use print_name_and_num
>     for other predicates. Document why we now consistently use print_name_only.
> 
> compiler/parse_tree_out.m:
>     Export a predicate for use by intermod.m, after carving it out of another
>     predicate.
>
>     Add a parameter to the predicates that output predicate declarations
>     to allow the caller to specify how type variables should be printed,
>     in case we want to change things again later.
> 
> compiler/parse_tree_out_pred_decl.m:
>     Add a parameter to the predicates that output parts of predicate
>     declarations to allow the caller to specify how type variables
>     should be printed, in case we want to change things again later.
>
>     Break up too-long lines.

That's fine.

Julien.


More information about the reviews mailing list