[m-rev.] for post-commit review: explain messages about sources of detism errors

Julien Fischer jfischer at opturion.com
Fri Aug 27 22:06:06 AEST 2021


On Fri, 27 Aug 2021, Zoltan Somogyi wrote:

> This is intended to fix the misunderstanding behind
> the origin of the "determinism issues with parser" thread
> on m-users in early july.

> Explain the components of determinism error msgs.
> 
> compiler/det_report.m:
>     When we report that a predicate does not satisfy the requirements
>     of its determinism declaration, we follow that statement with a list
>     of statements about pieces of code that all contribute to that mismatch.
>     However, a thread on m-users last month showed that some users did not
>     make that connection. So add an explicit statement to that effect.
> 
> tests/invalid/bug150.err_exp:
> tests/invalid/bug496.err_exp:
> tests/invalid/det_atomic_goal_msgs.err_exp:
> tests/invalid/det_errors.err_exp:
> tests/invalid/magicbox.err_exp:
> tests/invalid/not_a_switch.err_exp:
> tests/invalid/try_detism.err_exp:
> tests/invalid/user_field_access_decl_override.err_exp:
>     Expect updated error messages.

That's fine.

Julien.


More information about the reviews mailing list