[m-rev.] for review: replace item_id_sets

Zoltan Somogyi zoltan.somogyi at runbox.com
Fri Aug 27 21:48:15 AEST 2021


2021-08-27 21:44 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
>> +    % XXX I (zs) do not see why a decl_pragma *outside* a typeclass
>> +    % declaration should be able to apply to a class method that is declared
>> +    % *inside* the typeclass declaration. We should require that any
>> +    % decl pragma that is intended to apply to a class method
>> +    % should be declared next to it *inside the typeclass declaration itself*.
> 
> At the moment I don't think we allow anything inside typeclass declarations
> except pred, mode and func declarations.

Yes, I know. But having a pragma from outside the typeclass declaration
"reach into" the typeclass and affect one of its methods still feels wrong.
 
> The rest looks fine.

I made the correction; thanks for the review.

Zoltan.


More information about the reviews mailing list