[m-rev.] for post-commit review: inline build_module_with_options_and_redirect

Julien Fischer jfischer at opturion.com
Sat Aug 21 01:42:03 AEST 2021


On Thu, 19 Aug 2021, Zoltan Somogyi wrote:

> Inline build_module_with_options_and_output_redirect.
> 
> compiler/make.build.m:
> 
> compiler/make.build.m:
>     Delete build_module_with_options_and_output_redirect after inlining it
>     at its only call site. It added nothing but complexity and opacity.
>
>     Similarly inline and then delete the auxiliary predicates it used.
>
>     Delete the types that are not needed after the above.
> 
> compiler/make.module_target.m:
>     Inline build_module_with_options_and_output_redirect at its call site.

That's fine.

Julien.


More information about the reviews mailing list