[m-rev.] for post-commit review: inline build_with_output_redirect
Peter Wang
novalazy at gmail.com
Thu Aug 19 11:03:52 AEST 2021
On Wed, 18 Aug 2021 23:10:01 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> For review by anyone.
>
> Zoltan.
> Inline all calls to build_with_output_redirect.
>
> compiler/make.build.m:
> Delete build_with_output_redirect after inlining it at all its call sites.
> The resulting code is easier to understand, and crucially, it should be
> easier to modify to *avoid* redirecting the current output stream,
> with output going to explicitly specified streams instead.
>
> compiler/make.program_target.m:
> Inline build_with_output_redirect at its call sites.
That's fine.
Peter
More information about the reviews
mailing list