[m-rev.] for review: parsing .used files

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed Apr 21 01:45:14 AEST 2021


2021-04-20 17:02 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
> I think that's fine.  I would reorder the definitions so that
> the type used_classes/0 occurs immediately after used_file_items/0.

I will put in comments to document the structure of the types.

> I would also suggest that the new type be defined in its own module
> rather that in recompilation.usage.

Agreed, since recompilation.check.m will also need access to that type.
How about recompilation.used_file.m?

I don't think recompilation.usage.m is a good name.
recompilation.build_used_file.m, perhaps?
But a rename can wait until after the substantive changes.
 
Zoltan.


More information about the reviews mailing list