[m-rev.] for review: Disallow closures with partially instantiated direct arg arguments.
Peter Wang
novalazy at gmail.com
Thu Apr 15 17:22:54 AEST 2021
On Thu, 15 Apr 2021 17:06:09 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
>
> 2021-04-15 17:02 GMT+10:00 "Peter Wang" <novalazy at gmail.com>:
> > + % We did allow a closure to be constructed from a clone procedure,
> > + % but that leaves the HLDS in an inconsistent state, e.g. the type
> > + % and inst of the closure variable needs to be updated for the
> > + % extra arguments, and it gets a lot more complicated than that.
> > + % While the float registers pass is the only part of the compiler
> > + % known to break on the inconsistency, that may only be due to the
> > + % the rarity of higher order terms with daio arguments. Leaving the
> > + % HLDS in an inconsistent state is a bad idea anyway.
>
> Please add a reference to the date of the discussion.
Ok, done.
Peter
More information about the reviews
mailing list