[m-rev.] for review: Make subtypes inherit user-defined equality/comparison from base type.

Peter Wang novalazy at gmail.com
Tue Apr 13 11:39:46 AEST 2021


On Mon, 12 Apr 2021 17:14:21 +1000 Julien Fischer <jfischer at opturion.com> wrote:
> 
> > diff --git a/tests/invalid/subtype_user_compare.err_exp b/tests/invalid/subtype_user_compare.err_exp
> > new file mode 100644
> > index 000000000..c2dc66217
> > --- /dev/null
> > +++ b/tests/invalid/subtype_user_compare.err_exp
> > @@ -0,0 +1,2 @@
> > +subtype_user_compare.m:015: Error: the subtype `citrus'/0 is not allowed to
> > +subtype_user_compare.m:015:   have user-defined equality or comparison.
> 
> I wonder whether it's worth providing a some extra explanation in the
> verbose form of this message, something like:
> 
>    Only base types are allowed to have user-defined equality or comparison.
> 

Ok, I've added that and followed your other suggestions.

Peter


More information about the reviews mailing list