[m-rev.] for review: Fix lookup switches on subtype enums.
Peter Wang
novalazy at gmail.com
Fri Apr 9 17:23:52 AEST 2021
On Fri, 09 Apr 2021 17:12:36 +1000 Julien Fischer <jfischer at opturion.com> wrote:
> >
> > compiler/ml_lookup_switch.m:
> > Expect generated lookup table to contain dummy rows or not
>
> *the* generated lookup
>
> > depending on on dont_need_bit_vec_check_{with_gaps,no_gaps}.
>
> Doubled-up "on" there.
>
Fixed and fixed.
> > diff --git a/compiler/switch_util.m b/compiler/switch_util.m
> > index 720fc9241..85cb53cb8 100644
> > --- a/compiler/switch_util.m
> > +++ b/compiler/switch_util.m
> > @@ -176,7 +176,8 @@
> >
> > :- type need_bit_vec_check
> > ---> need_bit_vec_check
> > - ; dont_need_bit_vec_check.
> > + ; dont_need_bit_vec_check_no_gaps
> > + ; dont_need_bit_vec_check_with_gaps.
>
> It would be good to have a comment on this type describing the
> distinction between the latter two cases.
Done.
Peter
More information about the reviews
mailing list