[m-rev.] for review: Fix tabling of subtypes.

Julien Fischer jfischer at opturion.com
Fri Apr 9 15:43:15 AEST 2021


On Wed, 7 Apr 2021, Peter Wang wrote:

...

> diff --git a/tests/tabling/table_subtype_du.m b/tests/tabling/table_subtype_du.m
> new file mode 100644
> index 000000000..4470b263e
> --- /dev/null
> +++ b/tests/tabling/table_subtype_du.m
> @@ -0,0 +1,76 @@

...

> +:- type base_foo
> +    --->    foo_0
> +    ;       foo_1
> +    ;       foo_2
> +    ;       foo_3
> +    ;       bar(int, int)
> +    ;       foo_4
> +    ;       foo_5
> +    ;       foo_6
> +    ;       foo_7
> +    ;       foo_8
> +    ;       baz(int)
> +    ;       foo_10
> +    ;       foo_11
> +    ;       foo_12
> +    ;       foo_13
> +    ;       foo_14
> +    ;       foo_15.
> +
> +:- type foo =< base_foo
> +    --->    baz(int)
> +    ;       bar(int, int).  % deliberated reordered

s/deliberated/deliberately/

...

> diff --git a/tests/tabling/table_subtype_enum.m b/tests/tabling/table_subtype_enum.m
> new file mode 100644
> index 000000000..2b7b29511
> --- /dev/null
> +++ b/tests/tabling/table_subtype_enum.m

...

> @@ -0,0 +1,75 @@
> +:- type base_foo
> +    --->    foo_0
> +    ;       foo_1
> +    ;       foo_2
> +    ;       foo_3
> +    ;       bar     % 4
> +    ;       foo_5
> +    ;       foo_6
> +    ;       foo_7
> +    ;       foo_8
> +    ;       foo_9
> +    ;       baz     % 10
> +    ;       foo_11
> +    ;       foo_12
> +    ;       foo_13
> +    ;       foo_14
> +    ;       foo_15.
> +
> +:- type foo =< base_foo
> +    --->    baz     % 10
> +    ;       bar.    % 4 (deliberated reordered)

And again.

Looks ok otherwise.

Julien.


More information about the reviews mailing list