[m-rev.] for review: derive getopt.m and getopt_io.m from same template

Julien Fischer jfischer at opturion.com
Sat Sep 19 21:50:05 AEST 2020


On Sat, 19 Sep 2020, Zoltan Somogyi wrote:

> 2020-09-18 17:08 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
>> I suggest defining the following variable somewhere in this Mmakefile
>>
>>    SED=sed
>>
>> and using the variable in these rules insteaed of hardcoding it as sed.
>> (That gives us the option of choosing which sed to use on systems where
>> the default sed may not be the one to use.)
>
> Done. And thanks for the two big catches below.

There's a more subtle problem I didn't catch :-(  With this change the
following now fail during bootcheck:

     hard_coded/getopt_test in grade asm_fast.gc
     hard_coded/space in grade asm_fast.gc
     valid/bug134 in grade asm_fast.gc
     warnings/ambiguous_overloading in grade asm_fast.gc

(I think the issue is due to chmod bumping the timestamp on getopt.m
and the stage 2 compiler thinking it needs to rebuild the generated files.)

Julien.


More information about the reviews mailing list