[m-rev.] for review: Delete mkinit_erl program.
Julien Fischer
jfischer at opturion.com
Mon Oct 26 18:57:23 AEDT 2020
On Mon, 26 Oct 2020, Peter Wang wrote:
> util/.gitignore:
> util/Mmakefile:
> Don't build or install the mkinit_erl program.
>
> util/mkinit.c:
> util/mkinit_common.c:
> Remove references to mkinit_erl.c.
>
> Delete handling of -m option (only used by mkinit_erl).
>
> util/mkinit_erl.c:
> Delete source file.
...
> diff --git a/util/mkinit_common.c b/util/mkinit_common.c
> index 329e999d7..93010b627 100644
> --- a/util/mkinit_common.c
> +++ b/util/mkinit_common.c
> @@ -11,7 +11,7 @@
> ** File: mkinit_common.c
> ** Main authors: zs, fjh
> **
> -** Common code shared by mkinit.c and mkinit_erl.c.
> +** Common code previously shared by mkinit.c and mkinit_erl.c.
> **
> */
I wonder if it's worth merging it back into mkinit.c?
Looks fine otherwise.
Julien.
More information about the reviews
mailing list