[m-rev.] for review: drop support for versions of macOS prior to 10.9

Peter Wang novalazy at gmail.com
Mon Oct 26 12:01:32 AEDT 2020


On Sun, 25 Oct 2020 22:52:09 +1100 Julien Fischer <jfischer at opturion.com> wrote:
> diff --git a/NEWS b/NEWS
> index a547f76..617226e 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -11,6 +11,11 @@ Changes that may break compatibility
> 
>   * We have removed the legacy support for the Alpha architecture.
> 
> +* We have dropped support for all versions of macOS prior to 10.9.
> +
> +  A consequence of this is that the `powerpc*apple*darwin*` configuration
> +  is no longer supported.
> +

I think only one paragraph is required.

Maybe an inclusive version range would be less likely to be
misunderstood:

    We have dropped support for macOS 10.8 and earlier.

> diff --git a/compiler/compile_target_code.m b/compiler/compile_target_code.m
> index 793516f..8f94c30 100644
> --- a/compiler/compile_target_code.m
> +++ b/compiler/compile_target_code.m
> @@ -433,22 +433,6 @@ gather_c_compiler_flags(Globals, PIC, AllCFlags) :-
>           WarningOpt = ""
>       ),
> 
> -    % The -floop-optimize option is incompatible with the global
> -    % register code we generate on Darwin PowerPC.
> -    % See the hard_coded/ppc_bug test case for an example
> -    % program which fails with this optimization.

Maybe delete the ppc_bug test case.

The change looks fine though.

Peter


More information about the reviews mailing list