[m-rev.] for post-commit review: fix Mantis bug #522

Zoltan Somogyi zoltan.somogyi at runbox.com
Fri Oct 9 18:54:31 AEDT 2020


2020-10-09 12:34 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
> There's at least one other spot where we are still exceeding the limit
> 
>    Making Java class files
>    Mercury/javas/jmercury/libs__handle_options.java:3473: error: code too large
>    convert_options_to_globals_24_p_0(

That predicate has been the largest in the compiler for a long time now:
1700+ lines, with the next longest predicate that isn't a collection of facts
being just 620 lines. I will look into it, but I know it is a hornet's nest.
(Unlike the fifth entry on the attached size list, in which the attached diff
eliminates a whole bunch of duplicate code.)

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: LC.s.gz
Type: application/x-gzip
Size: 236029 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20201009/d32cf711/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.const_prop
Type: application/octet-stream
Size: 65164 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20201009/d32cf711/attachment-0001.obj>


More information about the reviews mailing list