[m-rev.] for review: shell script fixes

Zoltan Somogyi zoltan.somogyi at runbox.com
Fri May 29 18:28:08 AEST 2020


I just learned about a linter for shell scripts called shellcheck,
so I tried it out. It pointed out the issues fixed by this diff,
as well as other things that aren't problems.

For review by anyone. The main issue is whether the unused
variables that this diff deletes may nevertheless be needed.

Another issue this brought up for me is: should we prefer
modern bash-isms such as $(...) over the old Bourne sh
equivalents such as `...`? Any opinions?

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.sc
Type: application/octet-stream
Size: 945 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20200529/f6e3df5f/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.sc
Type: application/octet-stream
Size: 8713 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20200529/f6e3df5f/attachment-0001.obj>


More information about the reviews mailing list