[m-rev.] for post-commit review: add mmake targets for .all_{cs, javas, css} to .dv files

Julien Fischer jfischer at opturion.com
Mon May 25 13:23:35 AEST 2020


Hi Zoltan,

On Mon, 25 May 2020, Zoltan Somogyi wrote:

> For post-commit review by Julien.

...

> Define .all_{cs,javas,css} rules for mmake.
> 
> compiler/write_deps_file.m:
>     Generate a rule for the <module>.all_cs target for the top module's
>     .dv file the same way as for the <module>.cs target, and similarly
>     for <module>.all_javas and <module>.all_css. (We already generated
>     rules for the <module>.all_os and <module>.all_pic_os targets.)
>     There was no similar rule for Erlang.
>
>     Give names to some previously-nameless mmake rules.
>
>     Add an XXX.
> 
> compiler/options.m:
>     Allow the presence of this change to be tested.
> diff --git a/compiler/options.m b/compiler/options.m
> index 6f3e17b3a..5feb0fd84 100644
> 
> diff --git a/compiler/write_deps_file.m b/compiler/write_deps_file.m
> index 8614f1090..570d775f1 100644
> --- a/compiler/write_deps_file.m
> +++ b/compiler/write_deps_file.m
> 
> 
> @@ -554,7 +562,8 @@ generate_d_file(Globals, ModuleAndImports, AllDeps, MaybeTransOptDeps,
>      add_mmake_entry(MmakeRuleMhMihOnC, !MmakeFile),
>
>      % The `.module_dep' file is made as a side effect of
> -    % creating the `.c', `.s', or `.java'.
> +    % creating the `.c' or `.java'.
> +    % XXX What about C# and Erlang?
>

IIRC, most of the mmake rules for Java that are _not_ required by
--use-mmc-make are long obsolete.  Back when we started working on the Java
backend we did have some support for it using plain mmake, however the Java
backend has required the use of mmc --make for many years now.  The reason
there is nothing for C# or Erlang is that they were added much later and have
always only used mmc --make.

In short, the non-C backends only require as much support in mmake as is required
to allow mmake --use-mmc-make to work; anything else is probably obsolete.

Julien.


More information about the reviews mailing list