[m-rev.] for possible post-commit objection: remove a ten year old workaround

Julien Fischer jfischer at opturion.com
Sat May 23 20:13:19 AEST 2020


On Sat, 23 May 2020, Zoltan Somogyi wrote:

>
> 2020-05-23 13:58 GMT+10:00 Julien Fischer<jfischer at opturion.com>:
>> No objection, but did you check that anywhere we call mmc --make foo.cs
>> has been updated to use mmc --make foo.all_cs?
>
> I thought I did, by doing a bootcheck in the csharp grade, which
> succeeded modulo test failures, as usual. However, on a second look,
> it had significantly fewer tests fail than usual (56 vs 70), so it seems
> that I changed something I didn't intend to change. I have therefore
> backed out the change, and added a note on the workaround
> about it still being used.

I'm not sure about the test suite, but it looks as the the bootcheck
script still uses the old targets (e.g. cs, css, javas) to build stage 3.
One thing here is that while mmc --make and mmake --use-mmc-make
support the all-{cs,css,javas} targets, plain mmake doesn't appear to.
(It's possible that was the migration being referred to by the comment.)

Julien.


More information about the reviews mailing list